----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review153871 -----------------------------------------------------------
src/Makefile.am (line 1006) <https://reviews.apache.org/r/52786/#comment223402> Why did you put it into "containerizer/**" folder? src/tests/containerizer/health_check_test_helper.hpp (line 20) <https://reviews.apache.org/r/52786/#comment223403> What do you need this for? src/tests/containerizer/health_check_test_helper.hpp (line 41) <https://reviews.apache.org/r/52786/#comment223404> I understand you keep it as string because you use it as an env var later. Could you please explain this as comment? src/tests/containerizer/health_check_test_helper.cpp (lines 17 - 19) <https://reviews.apache.org/r/52786/#comment223406> Why these? src/tests/containerizer/health_check_test_helper.cpp (line 25) <https://reviews.apache.org/r/52786/#comment223405> Please make it the first include. src/tests/containerizer/health_check_test_helper.cpp (lines 27 - 28) <https://reviews.apache.org/r/52786/#comment223407> Ups? src/tests/containerizer/health_check_test_helper.cpp (lines 31 - 32) <https://reviews.apache.org/r/52786/#comment223408> Leftovers? - Alexander Rukletsov On Oct. 21, 2016, 11:12 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52786/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 11:12 a.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Bugs: MESOS-6278 > https://issues.apache.org/jira/browse/MESOS-6278 > > > Repository: mesos > > > Description > ------- > > This patch updates the test helper for the health check. Via starts a > simple HTTP server which listens on given IP and port, it makes testing > HTTP health check and TCP health check easier. > > > Diffs > ----- > > src/Makefile.am 05fe8fa3e3409b35ba66d7e7238e988fb0fab07d > src/tests/CMakeLists.txt f5d66dc63143455506d8660674fbd9eb227625ff > src/tests/containerizer/health_check_test_helper.hpp PRE-CREATION > src/tests/containerizer/health_check_test_helper.cpp PRE-CREATION > src/tests/test_helper_main.cpp 129a5e427b72fb577e55c3756d071f72ced9ff14 > > Diff: https://reviews.apache.org/r/52786/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
