> On Oct. 17, 2016, 12:34 p.m., Gastón Kleiman wrote: > > src/tests/containerizer/health_check_test_helper.cpp, line 66 > > <https://reviews.apache.org/r/52786/diff/1/?file=1532684#file1532684line66> > > > > Yhis method is so short, that I don't think we need this comment. > > > > But if you still think that it is needed, I'd remove the last part > > ('`which means that the authentication realm for libprocess-level HTTP > > endpoints was not set to the correct value for the master.`'), since it > > only applies to the Mesos Agent.
Thank you very much! Refer to `launcher/executor.cpp`, call `initialize` in not necessary here. Let me remove it. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review152863 ----------------------------------------------------------- On Oct. 17, 2016, 2:51 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52786/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 2:51 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Bugs: MESOS-6278 > https://issues.apache.org/jira/browse/MESOS-6278 > > > Repository: mesos > > > Description > ------- > > This patch updates the test helper for the health check. Via starts a > simple HTTP server which listens on given IP and port, it makes testing > HTTP health check and TCP health check easier. > > > Diffs > ----- > > src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 > src/tests/CMakeLists.txt f5d66dc63143455506d8660674fbd9eb227625ff > src/tests/containerizer/health_check_test_helper.hpp PRE-CREATION > src/tests/containerizer/health_check_test_helper.cpp PRE-CREATION > src/tests/test_helper_main.cpp 129a5e427b72fb577e55c3756d071f72ced9ff14 > > Diff: https://reviews.apache.org/r/52786/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
