----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52863/#review153578 -----------------------------------------------------------
Fix it, then Ship it! src/health-check/health_checker.cpp (lines 658 - 662) <https://reviews.apache.org/r/52863/#comment222982> Can you remove this default and add the UNKNOWN case instead? This way, we will get a compile failure if a new HealthCheck::Type is added but we don't update this switch. This is the pattern we've been trying to use going forward, see: https://issues.apache.org/jira/browse/MESOS-3754 - Benjamin Mahler On Oct. 14, 2016, 12:35 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52863/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 12:35 p.m.) > > > Review request for mesos, Gastón Kleiman and haosdent huang. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/health-check/health_checker.cpp > 96ae1a733ff3d211b84d0893b4603873af1c89f0 > > Diff: https://reviews.apache.org/r/52863/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
