----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53099/#review153597 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Oct. 21, 2016, 7:42 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53099/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 7:42 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6445 > https://issues.apache.org/jira/browse/MESOS-6445 > > > Repository: mesos > > > Description > ------- > > Although this is likely to remain small in practice, passing by const > reference should be preferred until there is a reason not to. > > > Diffs > ----- > > src/master/master.hpp 6d2db9de52d35f3288c618d05138413ce709818b > src/master/master.cpp 3f3ce93155069dd32731783ac4877ba6ee2519c0 > > Diff: https://reviews.apache.org/r/53099/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >