----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review154406 -----------------------------------------------------------
src/docker/docker.hpp (line 313) <https://reviews.apache.org/r/50128/#comment223931> You should also include `ostream` after #21 ``` #include <ostream> ``` src/docker/docker.cpp (line 1491) <https://reviews.apache.org/r/50128/#comment223932> I'd prefer that you include <ostream> at the beginning and use the following definition here directly. ``` ostream& operator<<(ostream& stream, const Docker::Device& device) ``` You can take a look at https://github.com/apache/mesos/blob/master/src/authorizer/acls.cpp as a reference. - Guangya Liu On 十一月 1, 2016, 9:11 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 十一月 1, 2016, 9:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper function to stringify 'Docker::Device' structure. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
