----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review153838 -----------------------------------------------------------
src/docker/docker.hpp (lines 71 - 74) <https://reviews.apache.org/r/50128/#comment223336> I don't think we want a version of this function that takes 3 parameters. If we wanted a "constructor" like this, we would just write a constructor (which we typically don't do for structs). Instead this function should just take a string, and have logic to parse that string into a `Device` type (as you do in a subsequent commit). src/docker/docker.cpp (line 388) <https://reviews.apache.org/r/50128/#comment223338> Add an error here to verify correct set of permissions in the permissions field. Once we have done all of this validation, we know it is safe to set the fields as we do below without error. src/docker/docker.cpp (lines 389 - 392) <https://reviews.apache.org/r/50128/#comment223337> Given the comment above, we should just leave this code as it was. - Kevin Klues On Oct. 24, 2016, 4:59 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 4:59 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper functions to 'Docker::Device' to handle data > parsing and serializing between 'Docker::Device' structure and > string. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
