> On Nov. 2, 2016, 11:05 a.m., Till Toenshoff wrote: > > src/health-check/tcp_connect.cpp, line 78 > > <https://reviews.apache.org/r/51605/diff/4/?file=1549253#file1549253line78> > > > > I find it very unfortunate that we are using raw `socket` and > > `sockeraddr_in` here. If only `Address` was not part of libprocess but of > > stout - VERY unfortunate. > > Once `Address` was part of stout, I feel there is no reason not to use > > `Address`, `net::IP`, `net::socket` and `net::connect` anymore. This would > > buy us implicit Windows compatibility and implicit IPv6 compatibility. > > > > Actually, maybe we can directly link against libprocess here -- even > > though `Address` currently is header only, that may certainly change. So > > maybe we can link `libprocess.a` and hence wont have a dependency against > > `libmesos.so/dylib`. > > > > Would you consider adding a TODO that says so?
I completely agree with you, but right now the extra cost of bringing in stout and libprocess dependencies seems to outweight the benefits we may get. I hope IPv6 work will also clean up the abstractions we have and will allow us to migrate to stout and get all the benfits you mention. I'll add the TODO. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review154533 ----------------------------------------------------------- On Oct. 31, 2016, 6:55 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51605/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 6:55 p.m.) > > > Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-6119 > https://issues.apache.org/jira/browse/MESOS-6119 > > > Repository: mesos > > > Description > ------- > > To remove dependency on `bash` for TCP health checks, introduce > a separate light-weight binary (without libmesos dependency) for > probing TCP connections. > > > Diffs > ----- > > src/CMakeLists.txt 639f8678ba23c4d9a2ea0bf84fbc3d6fc9286ef3 > src/Makefile.am c2f9e442182110d0b450d4824600a4a791f8cf27 > src/health-check/CMakeLists.txt PRE-CREATION > src/health-check/tcp_connect.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51605/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/51607/ > > > Thanks, > > Alexander Rukletsov > >
