> On Sept. 6, 2016, 6:34 p.m., Avinash sridharan wrote: > > src/health-check/tcp_connect.cpp, line 74 > > <https://reviews.apache.org/r/51605/diff/1/?file=1490604#file1490604line74> > > > > Why tcpThreeway? we are not testing the TCP threeway handshake > > (implicitly we are, but still). Maybe `testTCPConnect`?
I had in mind implementing half-open TCP health check, but probably you're right. If we end up doing tcp half-open, we can rename the function. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review147880 ----------------------------------------------------------- On Sept. 2, 2016, 4:42 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51605/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 4:42 p.m.) > > > Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-6119 > https://issues.apache.org/jira/browse/MESOS-6119 > > > Repository: mesos > > > Description > ------- > > To remove dependency on `bash` for TCP health checks, introduce > a separate light-weight binary (without libmesos dependency) for > probing TCP connections. > > > Diffs > ----- > > src/CMakeLists.txt b14132abf49a73defd3e4774330b5227726b9207 > src/Makefile.am 96edf5b8a4135355ee412e5837e86165885975f8 > src/health-check/CMakeLists.txt PRE-CREATION > src/health-check/tcp_connect.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51605/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/51607/ > > > Thanks, > > Alexander Rukletsov > >
