> On Sept. 2, 2016, 4:53 p.m., haosdent huang wrote: > > src/Makefile.am, line 1377 > > <https://reviews.apache.org/r/51605/diff/1/?file=1490602#file1490602line1377> > > > > I think the name `mesos-tcp-connect` may be not clear enough. Should we > > add something like `health-check` into its name to indicate it is used for > > health check? > > Avinash sridharan wrote: > I agree with @haosdent on this. Would like to see `health-check` in the > suffix of the binary name.
Why? The binary establishes a TCP connection, which is not necessarily health check related? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51605/#review147671 ----------------------------------------------------------- On Sept. 2, 2016, 4:42 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51605/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 4:42 p.m.) > > > Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-6119 > https://issues.apache.org/jira/browse/MESOS-6119 > > > Repository: mesos > > > Description > ------- > > To remove dependency on `bash` for TCP health checks, introduce > a separate light-weight binary (without libmesos dependency) for > probing TCP connections. > > > Diffs > ----- > > src/CMakeLists.txt b14132abf49a73defd3e4774330b5227726b9207 > src/Makefile.am 96edf5b8a4135355ee412e5837e86165885975f8 > src/health-check/CMakeLists.txt PRE-CREATION > src/health-check/tcp_connect.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51605/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/51607/ > > > Thanks, > > Alexander Rukletsov > >
