> On Nov. 4, 2016, 11:04 a.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 3855 > > <https://reviews.apache.org/r/52642/diff/2/?file=1544209#file1544209line3855> > > > > `FrameworkInfo.role` is optional, though with a default value. > > > > First, do we want to rely on the default in the proto or make it > > explicit here? > > > > Second, if a framework is registered for the `*` role, is it allowed to > > reserve `*` resources? Afaik, we don't. Hence I wonder whether the check > > you've added into `validate()` is enough.
Frameworks registered with the `*` role cannot reserve resources. I added an explicit check that will also give the users a better error message. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/#review154888 ----------------------------------------------------------- On Nov. 4, 2016, 12:50 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52642/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 12:50 p.m.) > > > Review request for mesos, Alexander Rukletsov and Michael Park. > > > Bugs: MESOS-6142 > https://issues.apache.org/jira/browse/MESOS-6142 > > > Repository: mesos > > > Description > ------- > > Don't allow a reservation if the framework role doesn't match the role > of all the resources. > > > Diffs > ----- > > src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 > src/master/master.cpp 013bb592ba47b785c552e199633e4784e8aa71b1 > src/master/validation.hpp 035f721c610ae566c89a1cf0e65ff0df11679f15 > src/master/validation.cpp f690a9eacd278b51a52f5588dbeea377df074435 > src/tests/master_validation_tests.cpp > a5d8610bd61822cdf55cbc8d7056e5cf8fecfa54 > > Diff: https://reviews.apache.org/r/52642/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gastón Kleiman > >
