> On Nov. 8, 2016, 10:37 a.m., Alexander Rukletsov wrote: > > src/tests/master_validation_tests.cpp, lines 311-313 > > <https://reviews.apache.org/r/52642/diff/4/?file=1555400#file1555400line311> > > > > This test does not do what it says. It's a copy-paste of > > `ReserveOperationValidationTest.MatchingPrincipal)`. Could you please fix > > it.
https://reviews.apache.org/r/53571/ > On Nov. 8, 2016, 10:37 a.m., Alexander Rukletsov wrote: > > src/tests/master_validation_tests.cpp, lines 387-403 > > <https://reviews.apache.org/r/52642/diff/4/?file=1555400#file1555400line387> > > > > Again, the former test does not do what it says and should be killed in > > favour of the latter one. https://reviews.apache.org/r/53571/ - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/#review155276 ----------------------------------------------------------- On Nov. 8, 2016, 10:45 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52642/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 10:45 a.m.) > > > Review request for mesos, Alexander Rukletsov and Michael Park. > > > Bugs: MESOS-6142 > https://issues.apache.org/jira/browse/MESOS-6142 > > > Repository: mesos > > > Description > ------- > > Don't allow a reservation if the framework role doesn't match the role > of all the resources. > > > Diffs > ----- > > src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 > src/master/master.cpp 15ad5a647fc71d36ffd149893b3b9448a7d99323 > src/master/validation.hpp ed878ef64c6bc49cfa1738f97c7af047f06ffee7 > src/master/validation.cpp 658f0dd1085c83cd82f8d2b0e2c4ec0ba785bb92 > src/tests/master_validation_tests.cpp > 8697bb2dc05c54553066ace58553f0e40dfcb5f5 > > Diff: https://reviews.apache.org/r/52642/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gastón Kleiman > >
