----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53365/ -----------------------------------------------------------
(Updated Nov. 11, 2016, 12:33 a.m.) Review request for mesos and Anand Mazumdar. Changes ------- Updated the description to reflect the latest changes. Repository: mesos Description (updated) ------- It turns out that zlib does not always set the `msg` field, the calling code is expected to handle the case where `msg` is NULL. I discovered this while I was playing with the library during the implementation of a streaming decompressor. To resolve this issue, this patch introduces an GzipError, currently hidden to callers within an internal namespace, in order to produce error messages in a consistent (safe) manner. In addition, this patch moves the (in|de)flateInit2 and (in|de)flateEnd failures to ABORT the program, since these correspond to programming errors and we will need to invoke these constructors and destructors once we have streaming (de)compression support. Diffs (updated) ----- 3rdparty/stout/include/stout/gzip.hpp b78a8a31204ee585f8e4a88eaefe7346faa46b8d Diff: https://reviews.apache.org/r/53365/diff/ Testing ------- make check Thanks, Benjamin Mahler
