----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53365/ -----------------------------------------------------------
(Updated Nov. 8, 2016, 4:17 a.m.) Review request for mesos and Anand Mazumdar. Changes ------- Updated to include an `internal::GzipError` to clean up the error handling. Also updated to `ABORT` in the case of programming errors. Repository: mesos Description (updated) ------- It turns out that zlib does not always set the `msg` field, the calling code is expected to handle the case where `msg` is NULL. I discovered this while I was playing with the library during the implementation of a streaming decompressor. I've introduced an `internal::GzipError` to simplify the error handling, and I've updated the code to `ABORT` in the case of our own programming errors. Diffs (updated) ----- 3rdparty/stout/include/stout/gzip.hpp b78a8a31204ee585f8e4a88eaefe7346faa46b8d Diff: https://reviews.apache.org/r/53365/diff/ Testing ------- make check Thanks, Benjamin Mahler
