----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53556/#review155211 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/utils.hpp (line 23) <https://reviews.apache.org/r/53556/#comment225046> Not used here. src/slave/containerizer/mesos/provisioner/utils.hpp (line 26) <https://reviews.apache.org/r/53556/#comment225047> Not used here. src/slave/containerizer/mesos/provisioner/utils.cpp (line 22) <https://reviews.apache.org/r/53556/#comment225037> This can be removed here. I think we don't double include in the impl when the corresponding header already includes a file. src/slave/containerizer/mesos/provisioner/utils.cpp (line 25) <https://reviews.apache.org/r/53556/#comment225039> Already included in header. src/slave/containerizer/mesos/provisioner/utils.cpp (line 28) <https://reviews.apache.org/r/53556/#comment225038> Already included in header. src/slave/containerizer/mesos/provisioner/utils.cpp (line 59) <https://reviews.apache.org/r/53556/#comment225041> This seems to require #include <sys/types.h> #include <sys/stat.h> #include <fts.h> src/slave/containerizer/mesos/provisioner/utils.cpp (line 61) <https://reviews.apache.org/r/53556/#comment225043> `stout/os/strerror.hpp`. src/slave/containerizer/mesos/provisioner/utils.cpp (line 74) <https://reviews.apache.org/r/53556/#comment225042> `stout/path.hpp`. src/slave/containerizer/mesos/provisioner/utils.cpp (line 94) <https://reviews.apache.org/r/53556/#comment225044> `stout/posix/os.hpp`. src/slave/containerizer/mesos/provisioner/utils.cpp (line 104) <https://reviews.apache.org/r/53556/#comment225045> `stout/posix/rm.hpp`. - Benjamin Bannier On Nov. 7, 2016, 11:49 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53556/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 11:49 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > This fixes the headers in the provisioner utility. Previously, the > headers did not contain includes for any of the classes used in the > file. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/utils.hpp > 4efce0ed67312417495af8c884ce26ef6affaccb > src/slave/containerizer/mesos/provisioner/utils.cpp > 340cf48819679cdd8d08d76dcd2328234477a15f > > Diff: https://reviews.apache.org/r/53556/diff/ > > > Testing > ------- > > make check (OSX) > make check (CentOS 7) > msbuild ... (Windows 10) > > > Thanks, > > Joseph Wu > >
