----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53556/#review155282 -----------------------------------------------------------
Fix it, then Ship it! LGTM, only a couple more to go. I found these by looking at what http://include-what-you-use.org/ suggests (e.g., with https://github.com/jasonmp85/homebrew-iwyu if one removes the `#ifdef __linux__`). src/slave/containerizer/mesos/provisioner/utils.cpp (line 22) <https://reviews.apache.org/r/53556/#comment225160> Even though this is mentioned in `fts(3)`'s synopsis, I believe we don't actually require it (but we do require `sys/stat.h` for `S_IFCHDIR`). src/slave/containerizer/mesos/provisioner/utils.cpp (line 42) <https://reviews.apache.org/r/53556/#comment225161> This needs to be include first. src/slave/containerizer/mesos/provisioner/utils.cpp (line 67) <https://reviews.apache.org/r/53556/#comment225159> `stout/os/strerror.hpp`. src/slave/containerizer/mesos/provisioner/utils.cpp (line 98) <https://reviews.apache.org/r/53556/#comment225158> `string.h` - Benjamin Bannier On Nov. 8, 2016, 1:56 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53556/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 1:56 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > This fixes the headers in the provisioner utility. Previously, the > headers did not contain includes for any of the classes used in the > file. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/utils.hpp > 4efce0ed67312417495af8c884ce26ef6affaccb > src/slave/containerizer/mesos/provisioner/utils.cpp > 340cf48819679cdd8d08d76dcd2328234477a15f > > Diff: https://reviews.apache.org/r/53556/diff/ > > > Testing > ------- > > make check (OSX) > make check (CentOS 7) > msbuild ... (Windows 10) > > > Thanks, > > Joseph Wu > >
