> On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.cpp, line 22 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556097#file1556097line22> > > > > This can be removed here. > > > > I think we don't double include in the impl when the corresponding > > header already includes a file.
See my response to Qian's question below. TLDR: Yes we do :) > On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.hpp, line 26 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556096#file1556096line26> > > > > Not used here. > > Qian Zhang wrote: > It is required by `utils.cpp`. Ah, right. This should be moved into the `.cpp` file. > On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.hpp, line 23 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556096#file1556096line23> > > > > Not used here. Removed. > On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.cpp, line 28 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556097#file1556097line28> > > > > Already included in header. See above for these two. > On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.cpp, line 59 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556097#file1556097line59> > > > > This seems to require > > > > #include <sys/types.h> > > #include <sys/stat.h> > > #include <fts.h> Good catch. > On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.cpp, line 61 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556097#file1556097line61> > > > > `stout/os/strerror.hpp`. Included as an alias by `stout/error.hpp`. > On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.cpp, line 94 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556097#file1556097line94> > > > > `stout/posix/os.hpp`. This is why we include `stout/os.hpp`. > On Nov. 7, 2016, 3:07 p.m., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/provisioner/utils.cpp, line 104 > > <https://reviews.apache.org/r/53556/diff/1/?file=1556097#file1556097line104> > > > > `stout/posix/rm.hpp`. Included as an alias by `stout/os/rm.hpp`. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53556/#review155211 ----------------------------------------------------------- On Nov. 7, 2016, 4:56 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53556/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 4:56 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > This fixes the headers in the provisioner utility. Previously, the > headers did not contain includes for any of the classes used in the > file. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/utils.hpp > 4efce0ed67312417495af8c884ce26ef6affaccb > src/slave/containerizer/mesos/provisioner/utils.cpp > 340cf48819679cdd8d08d76dcd2328234477a15f > > Diff: https://reviews.apache.org/r/53556/diff/ > > > Testing > ------- > > make check (OSX) > make check (CentOS 7) > msbuild ... (Windows 10) > > > Thanks, > > Joseph Wu > >
