> On Nov. 11, 2016, 1:27 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2710-2713 > > <https://reviews.apache.org/r/53487/diff/3/?file=1561642#file1561642line2710> > > > > It looks like this may be introducing another problematic path for > > libprocess finalization, in that your continuation may run after libprocess > > is finalized and it expects 'this' to be valid. > > > > It would be great to check with Joesph Wu about this path being > > introduced since he has worked on libprocess finalization, and see if he > > has any input.
There shouldn't be much of an impact to finalization. When the process manager is finalized (but not deleted yet), it will close all existing HTTP connections and join all worker threads. That means the continuation to `parse(*request)` can only run asynchronously before the `process_manager` is finalized, or synchronously while the `process_manager`/`socket_manager` are finalized. In both of those cases, the `process_manager` pointer is still valid. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53487/#review155745 ----------------------------------------------------------- On Nov. 11, 2016, 11:57 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53487/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 11:57 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6466 > https://issues.apache.org/jira/browse/MESOS-6466 > > > Repository: mesos > > > Description > ------- > > Old libprocess style messages and routes not supporting request > streaming read the body from the piped reader. Otherwise, the > request is forwarded to the handler when the route supports > streaming. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > f389d3d3b671e301a7ac911ad87ab13289e8c82f > 3rdparty/libprocess/src/process.cpp > ab2b5a9d38a3001d6a5daa1807fecb630c4b154d > > Diff: https://reviews.apache.org/r/53487/diff/ > > > Testing > ------- > > make check (Tests are added in https://reviews.apache.org/r/53490 i.e., after > we add support to the `Connection` abstraction for request streaming) > > > Thanks, > > Anand Mazumdar > >
