----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/#review156393 -----------------------------------------------------------
Ship it! Could you also comment on why ignore after termination and not during killing of the task? In the description and also in the code. src/launcher/default_executor.cpp (line 622) <https://reviews.apache.org/r/52871/#comment226611> Re-phrase this? src/launcher/default_executor.cpp (lines 623 - 628) <https://reviews.apache.org/r/52871/#comment226612> Maybe a `.contains()` and `.at()` instead of `.get()`? - Benjamin Mahler On Nov. 14, 2016, 10:30 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52871/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 10:30 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > ------- > > After the task has been terminated, its health updates become > irrelevant and should be ignored. Now it is safe to start health > checks even if the task has been asked to terminate. Also if the > default executor shuts down, we can safely pause all health checkers. > > > Diffs > ----- > > src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf > > Diff: https://reviews.apache.org/r/52871/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
