----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/#review156865 -----------------------------------------------------------
Ship it! Ship It! - Gastón Kleiman On Nov. 23, 2016, 1:06 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52871/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 1:06 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > ------- > > After the task has been terminated, its health updates become > irrelevant and should be ignored. Also if the default executor > shuts down, we can safely stop all health checkers. > > Technically health checking should be stopped right before > TASK_KILLING update is sent to avoid subsequent TASK_RUNNING > updates, but the default executor currently does not support > TASK_KILLING. > > > Diffs > ----- > > src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf > > Diff: https://reviews.apache.org/r/52871/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
