> On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote: > > docs/health-checks.md, line 21 > > <https://reviews.apache.org/r/53610/diff/2/?file=1567486#file1567486line21> > > > > Isn't a major advantage of Mesos-native health checks is that you avoid > > the scalability problems of having a single scheduler handle the health > > checks for a potentially large number of tasks? > > Alexander Rukletsov wrote: > I though that's exactly what this sentence says : ) > > Alexander Rukletsov wrote: > How about: "Handling health checks in a scheduler requires extra > computation and for a potentially large number of tasks may cause scalability > problems."?
I think saying "extra computation" is misleading: if you want to do health checks for N tasks you need to do the same computation in total, it is just a question of how that computation is distributed over the cluster. How about something like: "Implementing health checks in the framework scheduler can be a performance bottleneck. If a framework is managing a large number of tasks, performing health checks for every task can cause scheduler performance problems." > On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote: > > docs/health-checks.md, line 19 > > <https://reviews.apache.org/r/53610/diff/2/?file=1567486#file1567486line19> > > > > The phrase "incorporating network failures in health check information > > is not always desirable" is vague. What is the specific concern here? > > Alexander Rukletsov wrote: > The concern is that the task may be perfectly fine, but the network > connection between the scheduler and the task is currently flaky, resulting > in health check failures. > > How about this: "moreover, network failures between the task and the > scheduler may make the latter think that the former is unhealthy, which might > not be the case." sgtm. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/#review156617 ----------------------------------------------------------- On Nov. 20, 2016, 6:52 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53610/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2016, 6:52 p.m.) > > > Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and > Till Toenshoff. > > > Bugs: MESOS-5597 > https://issues.apache.org/jira/browse/MESOS-5597 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/health-checks.md PRE-CREATION > docs/home.md a5811480de050352dca6c0f7e4e64d3d2351c2d5 > > Diff: https://reviews.apache.org/r/53610/diff/ > > > Testing > ------- > > https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1 > > > Thanks, > > Alexander Rukletsov > >
