> On Nov. 22, 2016, 8:34 p.m., Neil Conway wrote: > > docs/health-checks.md, line 23 > > <https://reviews.apache.org/r/53610/diff/2/?file=1567486#file1567486line23> > > > > I think this would benefit from some more discussion of the high-level > > architecture of Mesos-native health checks. For example: > > > > * the traditional "scheduler health check" pattern involves a single > > scheduler node and a collection of agents; Mesos-native health checks run > > on the agent. This improves scalability but means that detecting network > > faults is a separate concern. > > * when a task fails Mesos-native health checks, what happens to it? how > > does the framework scheduler learn about this? > > * what happens if a task is running on a partitioned agent -- will it > > still be health-checked? If those health-checks fail, will the task be > > terminated? > > > > Some of this is discussed below, but I think it would be better to > > briefly discuss it at the beginning of the document to set context for what > > follows.
I've rearranged the text a bit: brought delivery and failure sections before the anatomy of a health checked, merged them together, and [added drama](https://www.youtube.com/watch?v=316AzLYfAzw) about network partitions. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53610/#review156617 ----------------------------------------------------------- On Nov. 20, 2016, 6:52 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53610/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2016, 6:52 p.m.) > > > Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and > Till Toenshoff. > > > Bugs: MESOS-5597 > https://issues.apache.org/jira/browse/MESOS-5597 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/health-checks.md PRE-CREATION > docs/home.md a5811480de050352dca6c0f7e4e64d3d2351c2d5 > > Diff: https://reviews.apache.org/r/53610/diff/ > > > Testing > ------- > > https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1 > > > Thanks, > > Alexander Rukletsov > >
