----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/#review157484 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 263) <https://reviews.apache.org/r/54215/#comment228086> I took a quick look at `mesosphere/inky` and all repeating layers are empty, so this is fine for this case. However, I'm not sure whether there is a legitemate case which same non-empty layer can repeat in the same images multiple times. If that's possible then this code could break such image provisioning (unfortunately I can't reproduce such a case myself...) - Zhitao Li On Nov. 30, 2016, 6:54 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54215/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 6:54 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao > Li. > > > Bugs: MESOS-6654 > https://issues.apache.org/jira/browse/MESOS-6654 > > > Repository: mesos > > > Description > ------- > > This issue is exposed by pulling the 'mesosphere/inky' docker > image using registry puller. Due to the duplicate layer id > from the manifest, there are duplicate layer pathes passed > to the backend. The aufs backend cannot handle this case and > returns 'invalid arguments' error. Ideally, we should make > sure that layer paths that are passed to the backend are > unique. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > > Diff: https://reviews.apache.org/r/54215/diff/ > > > Testing > ------- > > make check > > Tested by the unit test > `ROOT_CURL_INTERNET_DockerDefaultEntryptRegistryPuller`. > > Manually tested using the `mesosphere/inky` image, which contains duplicate > layer ids. > > > Thanks, > > Gilbert Song > >
