----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54489/#review158372 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/getenv.hpp (line 31) <https://reviews.apache.org/r/54489/#comment229133> I'd probably add a comment here at least noting why there are two calls to `GetEnvironmentVariable`, the first to check if it exists, and the second to retrieve it, in order to avoid unncessary allocations. (It took me a minute to see this is what you meant.) 3rdparty/stout/include/stout/os/windows/temp.hpp (line 23) <https://reviews.apache.org/r/54489/#comment229135> You already caught this, but I'll point it out anyway :P - Andrew Schwartzmeyer On Dec. 7, 2016, 7:10 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54489/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 7:10 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, and > Joseph Wu. > > > Bugs: MESOS-6717 > https://issues.apache.org/jira/browse/MESOS-6717 > > > Repository: mesos > > > Description > ------- > > This commit will partially address MESOS-6717, specifically: the Agent > test harness's `environment.cpp` uses POSIX-specific constructs to find > a temporary directory to call `os::mkdtemp` on; since `/tmp` often does > not exist on Windows, it will cause all Agent tests to fail immediately, > because `os::mkdtemp` will fail when components of the patter do not > exist. > > This commit will begin the process of moving the POSIX-specific logic > for selecting a temporary directory to `os::temp` in preparation for > removing it from `environment.cpp`. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am fc020bbf65030eb69a42d5c402e38ecb145f4c0f > 3rdparty/stout/include/stout/os.hpp > cdcbbf488d110e33e796fb0b7414793391761abf > 3rdparty/stout/include/stout/os/getenv.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/getenv.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/temp.hpp > 823c97b30d8d2a940b6735b6d28ba2d3614e0b98 > 3rdparty/stout/include/stout/os/windows/getenv.hpp PRE-CREATION > 3rdparty/stout/include/stout/posix/os.hpp > 8443aa0cf0a8d8d52e36282611c2ab15ca4dd354 > 3rdparty/stout/include/stout/windows/os.hpp > 2f20ccc64e255a60a1b7f33d684969942f12e45f > > Diff: https://reviews.apache.org/r/54489/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
