----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54489/#review158747 -----------------------------------------------------------
Ship it! I don't know about the Windows helpers used in the Windows version, but POSIX lgtm, modulo Joseph's `getOrElse` change! - Greg Mann On Dec. 9, 2016, 7:47 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54489/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 7:47 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, and > Joseph Wu. > > > Bugs: MESOS-6717 > https://issues.apache.org/jira/browse/MESOS-6717 > > > Repository: mesos > > > Description > ------- > > This commit will partially address MESOS-6717, specifically: the Agent > test harness's `environment.cpp` uses POSIX-specific constructs to find > a temporary directory to call `os::mkdtemp` on; since `/tmp` often does > not exist on Windows, it will cause all Agent tests to fail immediately, > because `os::mkdtemp` will fail when components of the patter do not > exist. > > This commit will begin the process of moving the POSIX-specific logic > for selecting a temporary directory to `os::temp` in preparation for > removing it from `environment.cpp`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/temp.hpp > 823c97b30d8d2a940b6735b6d28ba2d3614e0b98 > 3rdparty/stout/include/stout/os/windows/temp.hpp > d1169dfc1e8edebe998add6e53df9b63574d83df > > Diff: https://reviews.apache.org/r/54489/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
