-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54489/#review158749
-----------------------------------------------------------
Note: This review breaks the `IOSwitchboardServerTests` on OSX only.
On OSX, the temporary directory is something other than `tmp`
(/var/folders/gs/..._.../T/), which is too long for these tests. I've
discussed a workaround with Kevin Klues, and will be pushing this fix along
with this change:
```
diff --git a/src/tests/containerizer/io_switchboard_tests.cpp
b/src/tests/containerizer/io_switchboard_tests.cpp
index 7a90262..ecadeee 100644
--- a/src/tests/containerizer/io_switchboard_tests.cpp
+++ b/src/tests/containerizer/io_switchboard_tests.cpp
@@ -118,7 +118,7 @@ TEST_F(IOSwitchboardServerTest, RedirectLog)
string socketPath = path::join(
sandbox.get(),
- "mesos-io-switchboard-" + UUID::random().toString());
+ "mesos-io-switchboard");
Try<Owned<IOSwitchboardServer>> server = IOSwitchboardServer::create(
false,
@@ -226,7 +226,7 @@ TEST_F(IOSwitchboardServerTest, AttachOutput)
string socketPath = path::join(
sandbox.get(),
- "mesos-io-switchboard-" + UUID::random().toString());
+ "mesos-io-switchboard");
Try<Owned<IOSwitchboardServer>> server = IOSwitchboardServer::create(
false,
@@ -348,7 +348,7 @@ TEST_F(IOSwitchboardServerTest, AttachInput)
string socketPath = path::join(
sandbox.get(),
- "mesos-io-switchboard-" + UUID::random().toString());
+ "mesos-io-switchboard");
Try<Owned<IOSwitchboardServer>> server = IOSwitchboardServer::create(
false,
```
- Joseph Wu
On Dec. 9, 2016, 11:47 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54489/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 11:47 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, and
> Joseph Wu.
>
>
> Bugs: MESOS-6717
> https://issues.apache.org/jira/browse/MESOS-6717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit will partially address MESOS-6717, specifically: the Agent
> test harness's `environment.cpp` uses POSIX-specific constructs to find
> a temporary directory to call `os::mkdtemp` on; since `/tmp` often does
> not exist on Windows, it will cause all Agent tests to fail immediately,
> because `os::mkdtemp` will fail when components of the patter do not
> exist.
>
> This commit will begin the process of moving the POSIX-specific logic
> for selecting a temporary directory to `os::temp` in preparation for
> removing it from `environment.cpp`.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/temp.hpp
> 823c97b30d8d2a940b6735b6d28ba2d3614e0b98
> 3rdparty/stout/include/stout/os/windows/temp.hpp
> d1169dfc1e8edebe998add6e53df9b63574d83df
>
> Diff: https://reviews.apache.org/r/54489/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
