----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review159025 -----------------------------------------------------------
src/linux/ldd.cpp (line 37) <https://reviews.apache.org/r/53791/#comment229954> IMHO this code is fairly obvious as is. We already do unnecessary parsing and copying in the rootfs caller, I don't think we should also make things worse here too. src/tests/containerizer/rootfs.cpp (line 136) <https://reviews.apache.org/r/53791/#comment229958> I think that a vector is obvious and a set doesn't make any improvement. src/tests/containerizer/rootfs.cpp (line 145) <https://reviews.apache.org/r/53791/#comment229959> AFAICT 2 is correct. src/tests/containerizer/rootfs.cpp (line 175) <https://reviews.apache.org/r/53791/#comment229960> Not AFAICT :) - James Peach On Dec. 13, 2016, 6:34 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53791/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 6:34 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > The dependencies for the programs we need in the Linux root > filesystem vary over time and across distributions. Since Stout > has support for parsing the library dependencies of ELF binaries, > use this to collect the necessary dependencies when constructing > a root filesystem for the tests. > > > Diffs > ----- > > src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 > src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f > src/tests/containerizer/rootfs.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53791/diff/ > > > Testing > ------- > > sudo make check (Fedora 24) > > > Thanks, > > James Peach > >
