> On Dec. 14, 2016, 1:10 a.m., Kevin Klues wrote: > > src/tests/containerizer/io_switchboard_tests.cpp, line 809 > > <https://reviews.apache.org/r/54720/diff/1/?file=1583056#file1583056line809> > > > > I think you need the new: > > ``` > > #ifdef __linux__ > > flags.agent_subsystems = None(); > > #endif > > ``` > > > > here.
Oh, I just copy pasted from another test in the file. Is this being introduced in a different review? > On Dec. 14, 2016, 1:10 a.m., Kevin Klues wrote: > > src/tests/containerizer/io_switchboard_tests.cpp, line 886 > > <https://reviews.apache.org/r/54720/diff/1/?file=1583056#file1583056line886> > > > > Wait until slvae recovered? Your future is on `slave::Slave::_recover` `_recover` execution only guarantees that containerizer is recovered. there are more steps for slave recovery to complete, which i didn't care for in this test. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54720/#review159085 ----------------------------------------------------------- On Dec. 13, 2016, 10:20 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54720/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 10:20 p.m.) > > > Review request for mesos, Anand Mazumdar and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Added a test that verifies container attach after agent restart. > > > Diffs > ----- > > src/tests/containerizer/io_switchboard_tests.cpp > 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6 > > Diff: https://reviews.apache.org/r/54720/diff/ > > > Testing > ------- > > make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1 > > > Thanks, > > Vinod Kone > >
