----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54720/#review159090 -----------------------------------------------------------
Modulo Kevin's comment around adding the agent subsystem flag. Similar to the earlier review, looks good minus a query around if establishing a connection is enough to ensure that the client can attach? src/tests/containerizer/io_switchboard_tests.cpp (lines 814 - 817) <https://reviews.apache.org/r/54720/#comment230051> Would look less jagged if all arguments are on the same line similar to the `MesosSchedulerDriver()` a few lines later. I can understand why you did it in this way since the other tests in this file do it in this way. src/tests/containerizer/io_switchboard_tests.cpp (line 891) <https://reviews.apache.org/r/54720/#comment230052> s/EXPECT_EQ/ASSERT_EQ Might be needed for the other tests in this file too. Otherwise, it might crash on the next line. src/tests/containerizer/io_switchboard_tests.cpp (lines 896 - 897) <https://reviews.apache.org/r/54720/#comment230053> hmm, is this enough verification to ensure that a container can be attached after an agent restart? IIUC, this just validates that we are able to establish a connection. What if a subsequent request fails with a non `OK()` response? - Anand Mazumdar On Dec. 13, 2016, 10:20 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54720/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 10:20 p.m.) > > > Review request for mesos, Anand Mazumdar and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Added a test that verifies container attach after agent restart. > > > Diffs > ----- > > src/tests/containerizer/io_switchboard_tests.cpp > 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6 > > Diff: https://reviews.apache.org/r/54720/diff/ > > > Testing > ------- > > make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1 > > > Thanks, > > Vinod Kone > >
