> On Dec. 14, 2016, 1:34 a.m., Anand Mazumdar wrote: > > src/tests/containerizer/io_switchboard_tests.cpp, lines 896-897 > > <https://reviews.apache.org/r/54720/diff/1/?file=1583056#file1583056line896> > > > > hmm, is this enough verification to ensure that a container can be > > attached after an agent restart? IIUC, this just validates that we are able > > to establish a connection. What if a subsequent request fails with a non > > `OK()` response? > > Vinod Kone wrote: > Yes, this test verifes that `IOSwitchboardTest.Attach` test works even > after agent restart. Just like that test this one doesn't send actual > requests, just tests connection. > > Of course, it is still valuable to write tests that send speific > `ATTACH_*` calls and verify them but those to me are different tests. I will > get to them after :)
gotcha, Dropping the issue. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54720/#review159090 ----------------------------------------------------------- On Dec. 13, 2016, 10:20 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54720/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 10:20 p.m.) > > > Review request for mesos, Anand Mazumdar and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Added a test that verifies container attach after agent restart. > > > Diffs > ----- > > src/tests/containerizer/io_switchboard_tests.cpp > 5bd9dc4a776fe8a0d04ed31aa167f10c394984e6 > > Diff: https://reviews.apache.org/r/54720/diff/ > > > Testing > ------- > > make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1 > > > Thanks, > > Vinod Kone > >
