----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/#review159391 -----------------------------------------------------------
include/mesos/oci/spec.proto (line 17) <https://reviews.apache.org/r/52349/#comment230386> +1 using oci.spec.image. Also, looks like they start to prefix with v1. Let's use that as well: ``` oci.spec.image.v1 ``` include/mesos/oci/spec.proto (line 64) <https://reviews.apache.org/r/52349/#comment230387> No need for the `Image` prefix here. include/mesos/oci/spec.proto (line 90) <https://reviews.apache.org/r/52349/#comment230384> How do we support parsing `annotations`? Should we use a different name so we can do manual parsing? Also, i'd like to introduce a common `Label` message instead of `EntryWithStringValue` - Jie Yu On Dec. 11, 2016, 2:15 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52349/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2016, 2:15 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6681 > https://issues.apache.org/jira/browse/MESOS-6681 > > > Repository: mesos > > > Description > ------- > > Add protobuf messages for OCI image spec. > > > Diffs > ----- > > include/mesos/oci/spec.hpp PRE-CREATION > include/mesos/oci/spec.proto PRE-CREATION > src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 > > Diff: https://reviews.apache.org/r/52349/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
