> On Dec. 16, 2016, 8:32 a.m., Jie Yu wrote: > > include/mesos/oci/spec.proto, line 64 > > <https://reviews.apache.org/r/52349/diff/6/?file=1581544#file1581544line64> > > > > No need for the `Image` prefix here.
Do you mean we name it as `ManifestList`? But it seems not consistent with what we did for Appc and Docker, we have the name like `ImageManifest` in both Appc spec and Docker and spec. > On Dec. 16, 2016, 8:32 a.m., Jie Yu wrote: > > include/mesos/oci/spec.proto, line 90 > > <https://reviews.apache.org/r/52349/diff/6/?file=1581544#file1581544line90> > > > > How do we support parsing `annotations`? > > > > Should we use a different name so we can do manual parsing? > > > > Also, i'd like to introduce a common `Label` message instead of > > `EntryWithStringValue` > How do we support parsing `annotations`? That's the suggested way to handle `map` in protobuf, see https://developers.google.com/protocol-buffers/docs/proto#maps (the backwards compatible way) for details, I think `annotations` will be automatically parsed in this way. > Also, i'd like to introduce a common `Label` message instead of > `EntryWithStringValue` Do you mean we rename `EntryWithStringValue` to `Label` and define it in a common place rather than in this file? - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52349/#review159391 ----------------------------------------------------------- On Dec. 11, 2016, 10:15 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52349/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2016, 10:15 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6681 > https://issues.apache.org/jira/browse/MESOS-6681 > > > Repository: mesos > > > Description > ------- > > Add protobuf messages for OCI image spec. > > > Diffs > ----- > > include/mesos/oci/spec.hpp PRE-CREATION > include/mesos/oci/spec.proto PRE-CREATION > src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 > > Diff: https://reviews.apache.org/r/52349/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
