----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54825/ -----------------------------------------------------------
Review request for mesos and Benjamin Hindman. Repository: mesos Description ------- process::Loop is a std::enable_shared_from_this. Using stack-allocated instances of classes derived from std::enable_shared_from_this is undefined behavior. Prevent creation of stack-allocated process::Loop instances by hiding the constructors and providing a factory method to be used instead. Diffs ----- 3rdparty/libprocess/include/process/loop.hpp b35f7e6cc2da9d1c840656f80410756ba80dbc48 Diff: https://reviews.apache.org/r/54825/diff/ Testing ------- Observed only known test failures with: * `make check` (OS X, clang-trunk, w/optimizations, SSL) * `make check` and `ROOT` tests on various Linux configurations in internal CI Thanks, Benjamin Bannier
