----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54825/ -----------------------------------------------------------
(Updated Jan. 9, 2017, 12:06 p.m.) Review request for mesos and Benjamin Hindman. Changes ------- Rebased. Repository: mesos Description ------- process::Loop is a std::enable_shared_from_this. Using stack-allocated instances of classes derived from std::enable_shared_from_this is undefined behavior. Prevent creation of stack-allocated process::Loop instances by hiding the constructors and providing a factory method to be used instead. Diffs (updated) ----- 3rdparty/libprocess/include/process/loop.hpp 53f62439752a6eb7cf870022e4965c9261fc3ba6 Diff: https://reviews.apache.org/r/54825/diff/ Testing ------- Observed only known test failures with: * `make check` (OS X, clang-trunk, w/optimizations, SSL) * `make check` and `ROOT` tests on various Linux configurations in internal CI Thanks, Benjamin Bannier
