-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54846/
-----------------------------------------------------------

(Updated Dec. 18, 2016, 5:30 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, 
and Lukas Loesche.


Bugs: MESOS-4812
    https://issues.apache.org/jira/browse/MESOS-4812


Repository: mesos


Description
-------

After Mesos could specify namespaces to enter to perform health checks,
the command health check in docker executor doesn't need to wrap
command with `docker exec` anymore. Remove `docker exec` aslo fixes
the problem when escape quote character in command health checks.


Diffs (updated)
-----

  src/docker/executor.cpp 94e116f06c0c729a90e5424c37edc39c7ba4cbe6 
  src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4 

Diff: https://reviews.apache.org/r/54846/diff/


Testing (updated)
-------

Added new test cases `HealthCheckTest.ROOT_DOCKER_DockerEnvironmentSetup` and 
run 

```
$ sudo ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest*"
[----------] Global test environment tear-down
[==========] 22 tests from 1 test case ran. (75423 ms total)
[  PASSED  ] 22 tests.
```


Thanks,

haosdent huang

Reply via email to