> On Dec. 12, 2016, 9:30 a.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1307 > > <https://reviews.apache.org/r/51027/diff/10/?file=1540692#file1540692line1307> > > > > s/a single slaveId/a single `slaveId`/ to be consistent.
Changed the wording to describe the events in plain english, previously I was describing methods. // Events that trigger allocations, e.g. adding an agent or a framework, // update the set of `allocationCandidates` with a single agent in the // former case and the set of all known agents in the latter. > On Dec. 12, 2016, 9:30 a.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1287-1288 > > <https://reviews.apache.org/r/51027/diff/10/?file=1540692#file1540692line1287> > > > > Does this work? > > > > ``` > > return allocate({slaveId}); > > ``` No, the hashset constructor allows an initializer list, I think `return allocate({slaveId});` would just scope `slaveId`. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review158818 ----------------------------------------------------------- On Oct. 18, 2016, 4:14 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51027/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 4:14 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus > Ma, and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Triggered allocations dispatch allocate() only > if there is no pending allocation in the queue. > - Allocation candidates are accumulated and only > cleared when enqueued allocations are processed. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c31471ee0f5d6836393bf87ff9ecfd8df835013 > src/master/allocator/mesos/hierarchical.cpp > c8f9492ee1b69e125a1e841116d22a578a9b524e > > Diff: https://reviews.apache.org/r/51027/diff/ > > > Testing > ------- > > make check > > note: check without filters depends on https://reviews.apache.org/r/51028 and > https://reviews.apache.org/r/52534 > > > Thanks, > > Jacob Janco > >
