> On Jan. 19, 2017, 2:45 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1273-1280 > > <https://reviews.apache.org/r/51027/diff/11/?file=1589270#file1589270line1273> > > > > This change introduces an additional trip through the allocator's queue > > after the allocation completes and before the delay is called. > > > > This would avoid it: > > > > ``` > > auto pid = self(); > > > > // TODO: Use process::loop for the allocation loop. > > allocate() > > .onAny([pid]() { > > delay(allocationInterval, self(), &Self::batch); > > } > > ``` > > > > Not sure if this was intentional or not.
This was unintentional, defer does not need to be called here. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review162229 ----------------------------------------------------------- On Jan. 12, 2017, 6:55 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51027/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2017, 6:55 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus > Ma, and Jiang Yan Xu. > > > Bugs: MESOS-6904 > https://issues.apache.org/jira/browse/MESOS-6904 > > > Repository: mesos > > > Description > ------- > > - Triggered allocations dispatch allocate() only > if there is no pending allocation in the queue. > - Allocation candidates are accumulated and only > cleared when enqueued allocations are processed. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > a6424d624864155e1c87a28a63b784512c5c8722 > src/master/allocator/mesos/hierarchical.cpp > 91b1ec43940a788459f045ca4a4b82d4e8373bca > > Diff: https://reviews.apache.org/r/51027/diff/ > > > Testing > ------- > > make check with the filters below > > Broken tests: > - TEST_F(HierarchicalAllocatorTest, SuppressAndReviveOffers), fix in 51028 > - TEST_F(HierarchicalAllocatorTest, AllocationRunsMetric), fix in 51028 > - TEST_F(HierarchicalAllocatorTest, AllocationRunTimerMetrics), fix in 51028 > - TEST_F(HierarchicalAllocatorTest, UpdateWeight), fix in 51028 > - TEST_P(HierarchicalAllocator_BENCHMARK_Test, AddAndUpdateSlave), fix in > 51028 > - TEST_F(HierarchicalAllocatorTest, SmallOfferFilterTimeout), fix in 52534 > - TEST_F(OversubscriptionTest, RescindRevocableOfferWithIncreasedRevocable), > fix in 51621 > > > Thanks, > > Jacob Janco > >
