> On Sept. 29, 2016, 3:06 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3623-3627 > > <https://reviews.apache.org/r/51028/diff/4/?file=1513695#file1513695line3623> > > > > Instead of killing this part, what about updating `offerCallback` > > function to record the number of `agents`? And then assert the number of > > `agents` here is same as number of agents in cluster.
Added in logging for the offer callbacks which do correspond to actual runs performed as suggested below, what do you think? - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review150798 ----------------------------------------------------------- On Sept. 28, 2016, 9:16 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51028/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 9:16 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Per MESOS-3157, if cluster events with the possibility > of triggering an allocation occur rapidly and test > assertions depend on gleaning information from assumed > order, it is likely they will fail due to lack of parity > between event and actual allocation. Ensure that expected > allocations occur. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 46553f6d501deb37862dd5ba48be1c114f6e6cb8 > > Diff: https://reviews.apache.org/r/51028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
