> On Sept. 29, 2016, 3:06 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3007-3011 > > <https://reviews.apache.org/r/51028/diff/4/?file=1513695#file1513695line3007> > > > > Just a question here, can we always guarantee only one `allocate()` > > will be called? I think that this depends on the speed of dispatching the > > `run` request.
Right, I took a look at this. I believe pausing the clock between the addSlave and addFramework messages is correct, this does depend on speed. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review150798 ----------------------------------------------------------- On Dec. 21, 2016, 5:58 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51028/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 5:58 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Per MESOS-3157, if cluster events with the possibility > of triggering an allocation occur rapidly and test > assertions depend on gleaning information from assumed > order, it is likely they will fail due to lack of parity > between event and actual allocation. Ensure that expected > allocations occur. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5 > > Diff: https://reviews.apache.org/r/51028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
