> On Dec. 13, 2016, 4:30 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3621-3629 > > <https://reviews.apache.org/r/51028/diff/4/?file=1513695#file1513695line3621> > > > > I think we are still intereted in the number of allocations and we > > expect to see them decrease because of batching. We don't use EXPECT on > > them but we print them out as part of the benchmark? > > Jacob Janco wrote: > Added this in. Ex test output: > > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/5 > Using 1000 agents and 1000 frameworks > Added 1000 frameworks in 18064us > Added 1000 agents in 5.229825secs performing 1000 allocations > Updated 1000 agents in 5.39987secs performing 1000 allocations > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/5 > (10708 ms)
A better snippet showing trend: [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 Using 1000 agents and 1 frameworks Added 1 frameworks in 866us Added 1000 agents in 616149us performing 5 allocations Updated 1000 agents in 351825us performing 3 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 (1014 ms) [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 Using 1000 agents and 50 frameworks Added 50 frameworks in 952us Added 1000 agents in 744594us performing 142 allocations Updated 1000 agents in 508415us performing 111 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 (1310 ms) [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/2 Using 1000 agents and 100 frameworks Added 100 frameworks in 1877us Added 1000 agents in 1.088271secs performing 179 allocations Updated 1000 agents in 867190us performing 135 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/2 (2006 ms) [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/3 Using 1000 agents and 200 frameworks Added 200 frameworks in 3357us Added 1000 agents in 1.516704secs performing 294 allocations Updated 1000 agents in 1.319724secs performing 215 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/3 (2894 ms) [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/4 Using 1000 agents and 500 frameworks Added 500 frameworks in 8704us Added 1000 agents in 2.890338secs performing 685 allocations Updated 1000 agents in 2.783646secs performing 513 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/4 (5734 ms) [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/5 Using 1000 agents and 1000 frameworks Added 1000 frameworks in 16440us Added 1000 agents in 5.211817secs performing 1000 allocations Updated 1000 agents in 5.439422secs performing 1000 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/5 (10726 ms) [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/6 Using 1000 agents and 3000 frameworks Added 3000 frameworks in 46501us Added 1000 agents in 14.495025secs performing 1000 allocations Updated 1000 agents in 14.99748secs performing 1000 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/6 (29611 ms) [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/7 Using 1000 agents and 6000 frameworks Added 6000 frameworks in 83773us Added 1000 agents in 28.992552secs performing 1000 allocations Updated 1000 agents in 29.068944secs performing 1000 allocations [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/7 (58237 ms) - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review158967 ----------------------------------------------------------- On Dec. 20, 2016, 12:05 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51028/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 12:05 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Per MESOS-3157, if cluster events with the possibility > of triggering an allocation occur rapidly and test > assertions depend on gleaning information from assumed > order, it is likely they will fail due to lack of parity > between event and actual allocation. Ensure that expected > allocations occur. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5 > > Diff: https://reviews.apache.org/r/51028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
