> On Dec. 12, 2016, 5 p.m., Jiang Yan Xu wrote: > > I feel it's hard to explain this patch without /r/51027/. It's probably > > better to have it go after /r/51027/ in the chain. It's fine if /r/51027/ > > requires this patch to pass the tests.
Yep, this this patch is necessary because of 51027. I'll chain accordingly. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review158858 ----------------------------------------------------------- On Dec. 21, 2016, 6:07 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52534/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 6:07 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jiang Yan > Xu. > > > Repository: mesos > > > Description > ------- > > - With an asynchronous `batch()` allocation, > this ensures that filters do not expire > before the next allocation. > - This patch should be reverted when allocation > occurs on resource recovery. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > a6424d624864155e1c87a28a63b784512c5c8722 > src/master/allocator/mesos/hierarchical.cpp > 91b1ec43940a788459f045ca4a4b82d4e8373bca > > Diff: https://reviews.apache.org/r/52534/diff/ > > > Testing > ------- > > With https://reviews.apache.org/r/51027/: > > GTEST_FILTER="-*SmallOfferFilter*" make check -j8 > > > Thanks, > > Jacob Janco > >
