----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review160885 -----------------------------------------------------------
Patch looks great! Reviews applied: [55334, 55335] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Jan. 9, 2017, 8:03 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55335/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 8:03 a.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu. > > > Bugs: MESOS-6894 > https://issues.apache.org/jira/browse/MESOS-6894 > > > Repository: mesos > > > Description > ------- > > These tests were using a `TaskInfo` field which is missing required > protobuf fields. After the dependeny patches begins to checkpoint > `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed, > thus caused these tests to fail. > > This patch backfills these fields to make these tests pass. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > 039f197ece893fdf95c25fe60bb827fa2d7a3cbf > > Diff: https://reviews.apache.org/r/55335/diff/ > > > Testing > ------- > > GTEST_FILTER="MesosContainerizer*" make check > > > Thanks, > > Zhitao Li > >