> On Jan. 9, 2017, 2:09 p.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/loop.hpp, lines 216-219 > > <https://reviews.apache.org/r/55339/diff/1/?file=1599914#file1599914line216> > > > > I think we can keep the constructor private, and just do: > > > > ``` > > friend class Continue; > > friend class Break; > > ```
Oops. I was wrong about this. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55339/#review160980 ----------------------------------------------------------- On Jan. 9, 2017, 5:43 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55339/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 5:43 a.m.) > > > Review request for mesos, Benjamin Bannier and Michael Park. > > > Bugs: MESOS-6895 > https://issues.apache.org/jira/browse/MESOS-6895 > > > Repository: mesos > > > Description > ------- > > The friend class declaration of nested, templated classes > will raise an error when compiling with Clang. > This is resolved by making the constructor of 'ControlFlow' public. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/loop.hpp > 53f62439752a6eb7cf870022e4965c9261fc3ba6 > > Diff: https://reviews.apache.org/r/55339/diff/ > > > Testing > ------- > > make check with > ``` > $ clang --version > Apple LLVM version 8.0.0 (clang-800.0.42.1) > Target: x86_64-apple-darwin16.3.0 > ``` > > > Thanks, > > Jan Schlicht > >
