----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55355/#review161007 -----------------------------------------------------------
Ship it! LGTM! - Jie Yu On Jan. 10, 2017, 12:02 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55355/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 12:02 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin > Mahler, Jie Yu, Joseph Wu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Previously, the IO switchboard could leak file descriptors > because it held a reference to its server socket within the > socket's accept loop. This patch explicitly discards the > future containing this reference to eliminate the leak. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 67c51678e87389ab08a81fe4832cffd3d83bdae9 > > Diff: https://reviews.apache.org/r/55355/diff/ > > > Testing > ------- > > Run: > `bin/mesos-tests.sh --gtest_repeat=-1 > --gtest_filter="IOSwitchboardServerTest.AttachInput"` > > and then simultaneously execute `sudo lsof -p PID_of_test_process | wc -l` > repeatedly to ensure that the number of open FDs is not increasing. > > > Thanks, > > Greg Mann > >
