----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55024/#review161171 -----------------------------------------------------------
3rdparty/libprocess/src/process.cpp (lines 1040 - 1041) <https://reviews.apache.org/r/55024/#comment232406> Even if this is idempotent, we can remove the call from some of our own binaries now. Also, what is the version check you mention here? 3rdparty/libprocess/src/process.cpp (line 1046) <https://reviews.apache.org/r/55024/#comment232407> s/teard down/teardown/ `process::finalize` should probably perform the socket teardown, or at least give the option to do so. Currently, very few of our processes call `process::finalize`. They usually just rely on the OS cleaning up after them. - Joseph Wu On Dec. 24, 2016, 2:46 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55024/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2016, 2:46 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Currently libprocess will attempt to use sockets without initializing > the socket stack on Windows. This commit will resolving this problem by > causing `process::initialize` to initialize the socket stack. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 889a03444eaee7b5ad2be65bb414c30062d4a4f0 > > Diff: https://reviews.apache.org/r/55024/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
