----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55024/#review162008 -----------------------------------------------------------
Fix it, then Ship it! I can make these slight tweaks before committing if you agree about the severity of failing to `net::wsa_cleanup()`. 3rdparty/libprocess/include/process/process.hpp (lines 528 - 529) <https://reviews.apache.org/r/55024/#comment233271> To conform with the doxygen formatting here, I'll change this to: ``` * @param finalize_wsa Whether the Windows socket stack should be cleaned * up for the entire process. Has no effect outside of Windows. ``` 3rdparty/libprocess/src/process.cpp (line 1037) <https://reviews.apache.org/r/55024/#comment233273> s/Stout/This call/ 3rdparty/libprocess/src/process.cpp (line 1328) <https://reviews.apache.org/r/55024/#comment233275> At the moment, I would not expect this to ever fail, `EXIT(EXIT_FAILURE)` is preferable. If it does, it seems like a severe enough error (as the docs suggest most errors are due to programmer error). See: https://msdn.microsoft.com/en-us/library/windows/desktop/ms741549(v=vs.85).aspx - Joseph Wu On Jan. 15, 2017, 12:46 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55024/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2017, 12:46 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Currently libprocess will attempt to use sockets without initializing > the socket stack on Windows. This commit will resolving this problem by > causing `process::initialize` to initialize the socket stack. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > b118f1a2bf5aac12b53ae204253b88c9b1c65f46 > 3rdparty/libprocess/src/process.cpp > f475fe78f801924f70f51fdc4ab190c2dbecd656 > > Diff: https://reviews.apache.org/r/55024/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
