----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/#review161625 -----------------------------------------------------------
Ship it! I can tweak the below comments before committing. 3rdparty/libprocess/src/tests/socket_tests.cpp (line 89) <https://reviews.apache.org/r/53803/#comment232882> Typo on `Parametrize` 3rdparty/libprocess/src/tests/socket_tests.cpp (lines 133 - 140) <https://reviews.apache.org/r/53803/#comment232885> To future proof this code, this macro should (unfortunately) be expanded into: ``` #ifdef USE_SSL_SOCKET INSTANTIATE_TEST_CASE_P( Encryption, NetSocketTest, ::testing::Values( string("SSL"), string("Non-SSL"))); #else INSTANTIATE_TEST_CASE_P( Encryption, NetSocketTest, ::testing::Values( string("Non-SSL"))); #endif // USE_SSL_SOCKET ``` By the looks of it, this test will be ported to Windows, which means that MSVC will refuse to expand the #ifdef inside the test macro. 3rdparty/libprocess/src/tests/socket_tests.cpp (lines 147 - 148) <https://reviews.apache.org/r/53803/#comment232883> Let's move this to the upper part of the file. - Joseph Wu On Jan. 11, 2017, 4:57 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53803/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2017, 4:57 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-6802 > https://issues.apache.org/jira/browse/MESOS-6802 > > > Repository: mesos > > > Description > ------- > > This patch adds NetSocketTest.EOFBeforeRecv and > NetSocketTest.EOFAfterRecv to verify that EOFs are > reliably received whether or not there is a pending recv() > request at the time the EOF is received. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/socket_tests.cpp > 44c3c9adc39702dd598aa0105088517df601bbda > > Diff: https://reviews.apache.org/r/53803/diff/ > > > Testing > ------- > > Testing details are at the end of this review chain. > > > Thanks, > > Greg Mann > >
