> On Nov. 23, 2016, 1:26 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 203-204 > > <https://reviews.apache.org/r/53803/diff/2/?file=1565276#file1565276line203> > > > > A lot of these comments seem to have a really long line followed by a > > really short line. I would suggest trying to wrap these comments to be a > > little less "jagged", as I find it's easier on the eyes, but up to you: > > > > ``` > > // This test verifies that an EOF sent on a socket will be correctly > > received by > > // the other end. > > ``` > > > > vs. > > > > ``` > > // This test verifies that an EOF sent on a socket > > // will be correctly received by the other end. > > ``` > > > > Ditto below.
Agreed! - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/#review156677 ----------------------------------------------------------- On Nov. 23, 2016, 6:17 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53803/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 6:17 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-5966 > https://issues.apache.org/jira/browse/MESOS-5966 > > > Repository: mesos > > > Description > ------- > > Added a new libprocess HTTP test. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > 533104c93dd1eaf67bf3752163d2e0cad090078d > > Diff: https://reviews.apache.org/r/53803/diff/ > > > Testing > ------- > > Testing details are at the end of this review chain. > > > Thanks, > > Greg Mann > >
