----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/#review162836 -----------------------------------------------------------
src/slave/slave.cpp (line 1579) <https://reviews.apache.org/r/55876/#comment234202> I feel like we use an underscore suffix (`task_`) more often than a prefix. Is there a rule here? src/slave/slave.cpp (line 1580) <https://reviews.apache.org/r/55876/#comment234203> Not yours, but is there a reason why this isn't written `if (task.slave_id() != info.id()) {...}` ? src/slave/slave.cpp (line 1679) <https://reviews.apache.org/r/55876/#comment234201> Also variable shadowing. - Neil Conway On Jan. 24, 2017, 2:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55876/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:54 p.m.) > > > Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 > > Diff: https://reviews.apache.org/r/55876/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
