----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/#review163288 -----------------------------------------------------------
Fix it, then Ship it! Variable naming still seems inconsistent, but I see we use both `var_` and `_var` in `slave.cpp`. Would be nice to be consistent but we can defer that to later. src/slave/slave.cpp (line 1580) <https://reviews.apache.org/r/55876/#comment234720> If we're going to change this, there are a few other places that should also be changed: e.g., lines 1179, 1226, 1580, potentially 5292. - Neil Conway On Jan. 27, 2017, 11:52 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55876/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 11:52 a.m.) > > > Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 > > Diff: https://reviews.apache.org/r/55876/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
