> On Jan. 24, 2017, 6:14 p.m., Neil Conway wrote: > > src/slave/slave.cpp, line 1579 > > <https://reviews.apache.org/r/55876/diff/1/?file=1613399#file1613399line1579> > > > > I feel like we use an underscore suffix (`task_`) more often than a > > prefix. Is there a rule here?
>From the naming section of our style guide: ``` We prepend constructor and function arguments with a leading underscore to avoid ambiguity and / or shadowing: Prefer trailing underscores for use as member fields (but not required). Some trailing underscores are used to distinguish between similar variables in the same scope (think prime symbols), but this should be avoided as much as possible, including removing existing instances in the code base. ``` - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/#review162836 ----------------------------------------------------------- On Jan. 24, 2017, 2:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55876/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:54 p.m.) > > > Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 > > Diff: https://reviews.apache.org/r/55876/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
